Skip to content

gh-139349: fix init dataclass Console init with value ignore repr error #139351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-139349: fix init dataclass Console init with value ignore repr error #139351

wants to merge 3 commits into from
+93 −2

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Sep 26, 2025 •
edited by bedevere-app bot
Loading

@yihong0618 yihong0618 changed the title fix: init dataclass Console init with value ignore repr error gh-139349: fix init dataclass Console init with value ignore repr error Sep 26, 2025
@yihong0618 yihong0618 marked this pull request as ready for review September 26, 2025 12:10
@bedevere-app bedevere-app bot mentioned this pull request Sep 26, 2025
Open
picnixz
picnixz requested changes Sep 26, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should use Console before prepare() has been called. Thus, this should likely not be fixed like that.

@bedevere-app
Copy link

bedevere-app bot commented Sep 26, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@yihong0618
fix: address comments
b2f9f6c 
Signed-off-by: yihong0618 <[email protected]>
picnixz
picnixz reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the console interface is a private implementation detail (_pyrepl is private and _pyrepl.readline._wrapper.reader is even more private, so no one should directly access it; if one incorrectly uses UnixConsole(), then something wrong may happen). I am still unconvinced that we should do anything here. I'll let @pablogsal or @ambv decide on the course of action here (though just removing console from the repr might be fine; however no NEWS should be added IMO).

@yihong0618
fix: skip news
7b581e2 
Signed-off-by: yihong0618 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz requested changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
awaiting changes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihong0618 @picnixz